Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we drop support for kubeadm v1beta1 types? #4507

Closed
fabriziopandini opened this issue Apr 21, 2021 · 21 comments
Closed

Should we drop support for kubeadm v1beta1 types? #4507

fabriziopandini opened this issue Apr 21, 2021 · 21 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@fabriziopandini
Copy link
Member

CABPK & KCP in the v1alpha4 branch support kubeadm API v1beta1, v1beta2 and soon v1beta3 (#4445).

This issue is about discussing the option to drop support for kubeadm v1beta1 types, which practically means that capi v1alpha4 cannot be used to create Kubernetes clusters < v1.15.

Now kubeadm v1.15 is N-6 as of today, this makes such release out of the skew support being discussed in #4464; however, given that this is not yet confirmed, I have opened a separated issue to see if we can get this cleanup moving.

/kind cleanup

@vincepri @CecileRobertMichon @sbueringer

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 21, 2021
@fabriziopandini fabriziopandini changed the title Should we drop support for kubeadm v1beta1 types Should we drop support for kubeadm v1beta1 types? Apr 21, 2021
@vincepri
Copy link
Member

I'm ok dropping support in v0.4

@sbueringer
Copy link
Member

+1 from me too.
Main argument for me is that supporting n-6 (and it will be a lot more at the time of the release and over the lifetime of v0.4.0) is not sustainable.

@CecileRobertMichon
Copy link
Contributor

Main argument for me is that supporting n-6 (and it will be a lot more at the time of the release and over the lifetime of v0.4.0) is not sustainable.

+1 from me as well with the same reasoning

@vincepri
Copy link
Member

/milestone v0.4

@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Apr 21, 2021
@vincepri
Copy link
Member

/kind release-blocking

@k8s-ci-robot k8s-ci-robot added the kind/release-blocking Issues or PRs that need to be closed before the next CAPI release label Apr 21, 2021
@vincepri
Copy link
Member

/help

@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Apr 28, 2021
@gab-satchi
Copy link
Member

/assign

@vincepri
Copy link
Member

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label May 12, 2021
@fabriziopandini fabriziopandini removed the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label May 18, 2021
@fabriziopandini
Copy link
Member Author

/milestone next
This should wait after we remove v1alpha3 API (v1alpha3 API is embedding kubeadm v1beta1 types 😞 )

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The provided milestone is not valid for this repository. Milestones in this repository: [Next, v0.3, v0.4]

Use /milestone clear to clear the milestone.

In response to this:

/milestone next
This should wait after we remove v1alpha3 API (v1alpha3 API is embedding kubeadm v1beta1 types 😞 )

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini fabriziopandini modified the milestones: v0.4, Next May 18, 2021
@fabriziopandini fabriziopandini removed the kind/release-blocking Issues or PRs that need to be closed before the next CAPI release label May 18, 2021
@vincepri
Copy link
Member

Could we add a deprecation notice to the package at least?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 16, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 15, 2021
@neolit123
Copy link
Member

kubeadm v1beta1 was already removed in 1.22.
i will propose v1beta2 to be deprecated in 1.24 and it will be removed in e.g. 3+ releases.

@neolit123
Copy link
Member

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 15, 2021
@sbueringer
Copy link
Member

sbueringer commented Sep 15, 2021

/milestone next
This should wait after we remove v1alpha3 API (v1alpha3 API is embedding kubeadm v1beta1 types 😞 )

Based on this and the current state of the v1beta1 discussion, we will have to wait until the next version after v1beta1 (I guess v1beta2) to drop this.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 14, 2021
@fabriziopandini
Copy link
Member Author

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 14, 2021
@sbueringer
Copy link
Member

As discussed in the backlog grooming on 11th February, we'll close this issue for now. We can only drop the kubeadm v1beta1 types once we drop our v1alpha3 types (as they are embedded there).

(we will drop them then)

/close

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closing this issue.

In response to this:

As discussed in the backlog grooming on 11th February, we'll close this issue for now. We can only drop the kubeadm v1beta1 types once we drop our v1alpha3 types (as they are embedded there).

(we will drop them then)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants