Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ remove ClusterConfiguration.UseHyperKubeImage from v1alpha4 #4545

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

ludusrusso
Copy link
Contributor

@ludusrusso ludusrusso commented Apr 28, 2021

What this PR does / why we need it:

This PR removes ClusterConfiguration.UseHyperKubeImage from v1alpha4 as discussed in #4542

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4542

/cc @fabriziopandini
/cc @vincepri

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @ludusrusso. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 28, 2021
@fabriziopandini
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 29, 2021
@ludusrusso ludusrusso force-pushed the issue/4542 branch 2 times, most recently from 9ba09bd to 8371c5b Compare April 29, 2021 12:15
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ludusrusso !
Only a couple of nits from my side

bootstrap/kubeadm/api/v1alpha3/conversion_test.go Outdated Show resolved Hide resolved
bootstrap/kubeadm/types/v1beta1/conversion_test.go Outdated Show resolved Hide resolved
bootstrap/kubeadm/types/v1beta2/conversion_test.go Outdated Show resolved Hide resolved
bootstrap/kubeadm/types/v1beta2/conversion_test.go Outdated Show resolved Hide resolved
controlplane/kubeadm/api/v1alpha3/conversion_test.go Outdated Show resolved Hide resolved
controlplane/kubeadm/api/v1alpha3/conversion_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

@ludusrusso: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-apidiff-main db47368 link /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vincepri
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2021
@fabriziopandini
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit f8816f8 into kubernetes-sigs:master Apr 29, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated hyperkube image support in ClusterConfiguration/v1alpha4
4 participants