Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UseHyperKubeImage setting in KubeadmControlPlane Spec should be mutable #4181

Closed
shysank opened this issue Feb 11, 2021 · 6 comments
Closed

UseHyperKubeImage setting in KubeadmControlPlane Spec should be mutable #4181

shysank opened this issue Feb 11, 2021 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Milestone
v0.4

Comments

@shysank
Copy link
Contributor

shysank commented Feb 11, 2021 •
edited
Loading

User Story

#2083 was created to make kcp spec fully mutable. But, since it's difficult to track every spec mutation in a single pr, we wanted to start with a few specs that were important, and move from there. As part of #3994 , the following specs in kcp were made mutable:

  • APIServer
  • ControllerManager
  • Scheduler

This story aims to track the UseHyperKubeImage settings in KCP

Detailed Description

Make UseHyperKubeImage spec in KubeadmControlPlane mutable

Anything else you would like to add:

v1beta1 in kubeadm has now been deprecated, so we need to keep that in mind when implementing this.

/kind feature
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 11, 2021
@neolit123
Copy link
Member

neolit123 commented Feb 11, 2021 •
edited
Loading

note that usage of hyperkube with kubeadm was deprecated in 1.17.
probably a better idea to just leave this field without any special treatment on the CAP* side.

@vincepri
Copy link
Member

We might want to remove this field from the v1alpha4 super-types cc @fabriziopandini

@vincepri
Copy link
Member

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Feb 11, 2021
@fabriziopandini
Copy link
Member

+1 for removal.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 16, 2021
@fabriziopandini
Copy link
Member

The field has been removed by #4545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
v0.4
Development

No branches or pull requests
6 participants
@neolit123 @vincepri @fabriziopandini @shysank @k8s-ci-robot @fejta-bot