Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Fix upgrade test (CoreDNS verification) #4470

Merged
merged 1 commit into from
Apr 13, 2021
Merged

🌱 Fix upgrade test (CoreDNS verification) #4470

merged 1 commit into from
Apr 13, 2021

Conversation

sbueringer
Copy link
Member

What this PR does / why we need it:
WIP/test PR for now. similar to #4469 just without the kind upgrade

Requires kubernetes/test-infra#21778 before merge

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 13, 2021
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-workload-upgrade-1-21-latest-main

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 13, 2021
@sbueringer sbueringer mentioned this pull request Apr 13, 2021
Merged
@sbueringer
Copy link
Member Author

Test was green: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/4470/pull-cluster-api-e2e-workload-upgrade-1-21-latest-main/1381904442139348992

Review findings addressed. I'll run it again with the fixes:
/test pull-cluster-api-e2e-workload-upgrade-1-21-latest-main

I'll drop this commit 3fd677a and squash after kubernetes/test-infra#21778 has been merged

@sbueringer sbueringer force-pushed the pr-fix-upgrade-test-fix-coredns branch from 716d5e5 to 07bb22c Compare April 13, 2021 11:13
@sbueringer sbueringer changed the title [WIP] Fix upgrade test (CoreDNS verification) Fix upgrade test (CoreDNS verification) Apr 13, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 13, 2021
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-workload-upgrade-1-21-latest-main

@sbueringer sbueringer changed the title Fix upgrade test (CoreDNS verification) 🌱 Fix upgrade test (CoreDNS verification) Apr 13, 2021
@sbueringer sbueringer mentioned this pull request Apr 13, 2021
Merged
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-workload-upgrade-1-21-latest-main

(only 7/10 nodes were ready before conformance test were started)

@sbueringer sbueringer force-pushed the pr-fix-upgrade-test-fix-coredns branch from 07bb22c to e2313d5 Compare April 13, 2021 14:45
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2021
@sbueringer
Copy link
Member Author

@fabriziopandini done

fabriziopandini
fabriziopandini reviewed Apr 13, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit aaea64e into kubernetes-sigs:master Apr 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Apr 13, 2021
@sbueringer sbueringer deleted the pr-fix-upgrade-test-fix-coredns branch April 13, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@sbueringer @k8s-ci-robot @fabriziopandini @JoelSpeed