🌱 Upgrade to kind v0.11.0 #4469
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/S
|
/test pull-cluster-api-e2e-workload-upgrade-1-21-latest-main |
sbueringer
force-pushed
the
pr-upgrade-kind
branch
from
a724c9e to
3e490c8
Compare
k8s-ci-robot
added
size/M
|
/test pull-cluster-api-e2e-workload-upgrade-1-21-latest-main |
1 similar comment
|
/test pull-cluster-api-e2e-workload-upgrade-1-21-latest-main |
sbueringer
force-pushed
the
pr-upgrade-kind
branch
from
4db84d5 to
bac30f5
Compare
k8s-ci-robot
added
size/L
|
/test pull-cluster-api-e2e-workload-upgrade-1-21-latest-main |
1 similar comment
|
/test pull-cluster-api-e2e-workload-upgrade-1-21-latest-main |
|
looks like cluster upgrade worked now, but I hit the 2h timeout which should not happen. Not sure how to debug this: Maybe it's a problem with the 1.22 e2e tests, there is currently no job to test 1.20=>1.21 on a PR. /test pull-cluster-api-e2e-workload-upgrade-1-21-latest-main |
|
Upgrade tests will be fixed here: #4470 I'll keep this PR for now for a PoC with the new kind version, but I'll wait until the kind release the next week (s) as we apparently don't need it to get the tests green (at least in Prow, I'm not sure about local) |
k8s-ci-robot
added
the
needs-rebase
sbueringer
force-pushed
the
pr-upgrade-kind
branch
from
da354e1 to
17f45b3
Compare
k8s-ci-robot
removed
the
needs-rebase
sbueringer
force-pushed
the
pr-upgrade-kind
branch
from
17f45b3 to
1113946
Compare
|
/test pull-cluster-api-e2e-full-main |
|
Now it's definitely just a test branch which I don't intend to merge. |
k8s-ci-robot
added
the
needs-rebase
|
@sbueringer @fabriziopandini What's the status for this update? |
Mainly that I was busy with other things the last 1-2 weeks and we're currently figuring out how we want to continue once kind is released. I'll will have time tomorrow to continue with PoCs. The current state is documented here https://docs.google.com/document/d/1zsxMrdQoXT01vkEnK9pnbVidtNfglBYoNMkHhEGqqM4/edit# (corresponding issue #4503) tl;dr from the doc is: out of the box the current kind main version won't work with Kubernetes >= 1.21 (because systemd cgroupDriver is default) without adjustments from our side. But there are a lot of easy workarounds imho (like settings cgroupDriver to Oh before I forget it. kind is not released yet, so it's all about making sure our tests won't break once kind is released. |
|
/retest |
There was a problem hiding this comment.
lgtm
please also update v1alpha3-to-v1alpha4.md https://github.com/kubernetes-sigs/cluster-api/blob/master/docs/book/src/developer/providers/v1alpha3-to-v1alpha4.md#kind-version
sbueringer
force-pushed
the
pr-upgrade-kind
branch
from
2650faa to
5dd65cb
Compare
|
@CecileRobertMichon updated the doc. I'm not sure if we should do anything about the minimum kind version mentioned in the quick start documentation: https://cluster-api.sigs.k8s.io/user/quick-start.html#install-andor-configure-a-kubernetes-cluster I'm not sure what it means that we "support" this kind version. There's nothing from our side which breaks compatibility with kind < v0.11 but we're only testing kind v0.11. /cc @fabriziopandini |
k8s-ci-robot
added
the
needs-rebase
sbueringer
force-pushed
the
pr-upgrade-kind
branch
from
5dd65cb to
b3f2840
Compare
|
/test pull-cluster-api-e2e-full-main |
k8s-ci-robot
removed
the
needs-rebase
|
/retest |
k8s-ci-robot
added
the
lgtm
sbueringer
force-pushed
the
pr-upgrade-kind
branch
from
b3f2840 to
6bb92ef
Compare
k8s-ci-robot
removed
the
lgtm
|
/test pull-cluster-api-e2e-full-main (only rebase) |
|
/test pull-cluster-api-e2e-workload-upgrade-1-21-latest-main |
|
@sbueringer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Ah, just forgot that the 1.21=>latest test is expected to fail at the moment |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
Upgrades to kind v0.11.0. Main reason for that is to get rid of #4405.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #4503
Related to #4405 (I want to verify the results posts-submit before closing #4405)