-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Clustectl v1alpha3 should block on v1alpha4 clusters #4265
⚠️ Clustectl v1alpha3 should block on v1alpha4 clusters #4265
Conversation
/test pull-cluster-api-test-release-0-3 |
/test pull-cluster-api-test-release-0-3 |
67fc438
to
2997f18
Compare
@fabriziopandini: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What this PR does / why we need it:
This is a backport of #4199
Cluster API v1alpha4 is introducing changes in how providers are deployed (see e.g webhooks running with manager).
As a consequence, clusterctl version v1alpha3 should not be allowed to run on v1alpha4 clusters
NB: While doing the change, also clusterctl version v1alpha3 should not be allowed to run on v1alpha2 clusters was implemented (this is not technically possible, but we are getting this for free while backporting), and tests are now refactored in order to make changes for supporting the next contract less invasive.
Which issue(s) this PR fixes:
Rif #4192
/milestone v0.3.x
/hold
for #4199 to merge