Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Clustectl v1alpha3 should block on v1alpha4 clusters #4265

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This is a backport of #4199

Cluster API v1alpha4 is introducing changes in how providers are deployed (see e.g webhooks running with manager).

As a consequence, clusterctl version v1alpha3 should not be allowed to run on v1alpha4 clusters

NB: While doing the change, also clusterctl version v1alpha3 should not be allowed to run on v1alpha2 clusters was implemented (this is not technically possible, but we are getting this for free while backporting), and tests are now refactored in order to make changes for supporting the next contract less invasive.

Which issue(s) this PR fixes:
Rif #4192

/milestone v0.3.x
/hold
for #4199 to merge

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.3.x milestone Mar 8, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 8, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 8, 2021
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test-release-0-3

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test-release-0-3

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2021
@fabriziopandini fabriziopandini force-pushed the clustectl-v1alpha3-should-block-on-v1alpha4-clusters branch from 67fc438 to 2997f18 Compare March 19, 2021 16:49
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2021
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-apidiff-release-0-3 2997f18 link /test pull-cluster-api-apidiff-release-0-3

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2021
@fabriziopandini
Copy link
Member Author

@vincepri this is a backport of #4199 and we get this merged first 😅

@vincepri
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 11c7f09 into kubernetes-sigs:release-0.3 Mar 23, 2021
@fabriziopandini fabriziopandini deleted the clustectl-v1alpha3-should-block-on-v1alpha4-clusters branch March 23, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants