Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ clustectl v1alpha4 should block when used with v1alpha3 management clusters #4199

Merged
merged 1 commit into from
Mar 23, 2021
Merged

⚠️ clustectl v1alpha4 should block when used with v1alpha3 management clusters #4199

merged 1 commit into from
Mar 23, 2021

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Feb 17, 2021 •
edited
Loading

What this PR does / why we need it:
Cluster API v1alpha4 is introducing changes in how providers are deployed (see e.g webhooks running with manager).

As a consequence, clusterctl version v1alpha4 should not be allowed to run on v1alpha3 clusters

NB: While doing the change, also clusterctl version v1alpha4 should not be allowed to run on v1alpha5 clusters was implemented, and tests are now refactored in order to make changes for supporting the next contract less invasive.

This will also ensure easier backport

Which issue(s) this PR fixes:
Rif #4191

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 17, 2021
JoelSpeed
JoelSpeed reviewed Feb 18, 2021
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2021
@fabriziopandini fabriziopandini force-pushed the clustectl-v1alpha4-should-block-on-v1alpha3-clusters branch from 8da293c to b5fcc2b Compare February 18, 2021 13:15
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2021
@fabriziopandini fabriziopandini force-pushed the clustectl-v1alpha4-should-block-on-v1alpha3-clusters branch from b5fcc2b to 24244fe Compare February 18, 2021 14:05
@fabriziopandini
Copy link
Member Author

@JoelSpeed sorry I didn't notice your review before force pushing.
I have refactored tests in order to make it easier to backport and to reduce the maintenance burden for every contract change

@fabriziopandini
Copy link
Member Author

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Feb 18, 2021
@fabriziopandini fabriziopandini force-pushed the clustectl-v1alpha4-should-block-on-v1alpha3-clusters branch from 24244fe to a81c6b6 Compare February 18, 2021 20:58
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2021
@fabriziopandini fabriziopandini force-pushed the clustectl-v1alpha4-should-block-on-v1alpha3-clusters branch from a81c6b6 to 30887e5 Compare March 4, 2021 10:25
@fabriziopandini
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2021
@fabriziopandini fabriziopandini mentioned this pull request Mar 8, 2021
Merged
@fabriziopandini fabriziopandini force-pushed the clustectl-v1alpha4-should-block-on-v1alpha3-clusters branch from 30887e5 to 9c7fbaf Compare March 8, 2021 14:23
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test-main

@fabriziopandini fabriziopandini mentioned this pull request Mar 8, 2021
Closed
3 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2021
@fabriziopandini fabriziopandini force-pushed the clustectl-v1alpha4-should-block-on-v1alpha3-clusters branch from 9c7fbaf to 1155588 Compare March 12, 2021 10:24
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-apidiff-main 1155588 link /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2021
vincepri
vincepri approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit f39a263 into kubernetes-sigs:master Mar 23, 2021
@fabriziopandini fabriziopandini deleted the clustectl-v1alpha4-should-block-on-v1alpha3-clusters branch March 23, 2021 17:48
@fabriziopandini fabriziopandini mentioned this pull request May 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@vincepri vincepri vincepri approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@vincepri vincepri

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziopandini @k8s-ci-robot @vincepri @JoelSpeed