Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add support to skip Machine remediation, and respect paused Machines in MHC #4168

Merged
merged 1 commit into from
Feb 18, 2021
Merged

✨ Add support to skip Machine remediation, and respect paused Machines in MHC #4168

merged 1 commit into from
Feb 18, 2021

Conversation

shysank
Copy link
Contributor

@shysank shysank commented Feb 10, 2021

What this PR does / why we need it:

  • Skips remediation for paused machines
  • Adds a new annotation to mark machines for skipping remediation

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4032

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 10, 2021
@shysank
Copy link
Contributor Author

shysank commented Feb 10, 2021

/test pull-cluster-api-test-main

CecileRobertMichon
CecileRobertMichon reviewed Feb 11, 2021
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2021
@vincepri
Copy link
Member

@shysank Was there a specific ask that I missed where we'd need a new annotation to avoid remediation?

@CecileRobertMichon
Copy link
Contributor

@vincepri from #4032:

@fabriziopandini also proposed introducing an MHC-specific annotation to only skip remediation while still keeping objects being reconciled.

@k8s-ci-robot k8s-ci-robot changed the title 🐛 Skip remediation for paused machines and those marked for skipping ✨ Add support to skip Machine reconciliation, and respect paused Machines Feb 11, 2021
vincepri
vincepri approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/milestone v0.4.0
/retitle ✨ Add support to skip Machine reconciliation, and respect paused Machines

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Feb 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2021
@vincepri
Copy link
Member

/retitle ✨ Add support to skip Machine remediation, and respect paused Machines in MHC

@k8s-ci-robot k8s-ci-robot changed the title ✨ Add support to skip Machine reconciliation, and respect paused Machines ✨ Add support to skip Machine remediation, and respect paused Machines in MHC Feb 11, 2021
@CecileRobertMichon
Copy link
Contributor

/retest

@shysank shysank mentioned this pull request Feb 16, 2021
Closed
@shysank
Copy link
Contributor Author

shysank commented Feb 16, 2021

/test pull-cluster-api-test-main

1 similar comment
@vincepri
Copy link
Member

/test pull-cluster-api-test-main

@vincepri
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit f905b7f into kubernetes-sigs:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@vincepri vincepri vincepri approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@moshloop moshloop Awaiting requested review from moshloop

Assignees

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

MHC should ignore paused machines
4 participants
@shysank @vincepri @CecileRobertMichon @k8s-ci-robot