Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHC should ignore paused machines #4032

Closed
yastij opened this issue Dec 18, 2020 · 6 comments · Fixed by #4168
Closed

MHC should ignore paused machines #4032

yastij opened this issue Dec 18, 2020 · 6 comments · Fixed by #4168
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@yastij
Copy link
Member

yastij commented Dec 18, 2020

What steps did you take and what happened:

Currently, MHC ignores paused MHCs/Clusters but not paused machines, this leads to machines being deleted when the pause annotation is removed, which isn't the desired intent.

@fabriziopandini also proposed introducing an MHC-specific annotation to only skip remediation while still keeping objects being reconciled.

cc @CecileRobertMichon @vincepri

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api version:
  • Minikube/KIND version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 18, 2020
@fabriziopandini
Copy link
Member

/milestone v0.4.0
IMO this is a candidate for backporting as well; this is another reason I'm+1 for having a separate annotation to add when the intent is to have MHC temporarily skip remediation on a machine.

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Dec 18, 2020
@vincepri
Copy link
Member

vincepri commented Jan 4, 2021

+1 to respect the paused annotation, and let's definitely backport to v0.3.x as well

@yastij
Copy link
Member Author

yastij commented Jan 4, 2021

/assign

@vincepri
Copy link
Member

vincepri commented Feb 9, 2021

/help
/assign @shysank

@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
/assign @shysank

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 9, 2021
@vincepri
Copy link
Member

vincepri commented Feb 9, 2021

/priority important-soon

We should also probably backport this change.

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants