Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Update kcp proposal disambiguating healthcheck #4093

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
In the KCP proposal we are using the term health with two different meanings:

  1. healthy machine, referring to the status of a set of configurable node conditions (inherited from MachineHealthCheck)
  2. healthy control plane or healthy etcd, referred to a set of preflight checks that KCP executes to ensure the control plane is stable before moving on with the next action (scale up, scale down, roll out)

This PR aligns the KCP proposal to the changes introduced by #3900 in the code for disambiguating the usage of healthy; As a consequence now we using health check is used only for 1, while we are using preflight check for 2.

While fixing this, I also added a sentence to document changes recently introduced by #4034

Which issue(s) this PR fixes:
Fixes #3875

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 20, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 20, 2021
@fabriziopandini
Copy link
Member Author

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Jan 20, 2021
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test-main

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2021
@vincepri
Copy link
Member

/retest

1 similar comment
@vincepri
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 23ab563 into kubernetes-sigs:master Jan 21, 2021
@fabriziopandini fabriziopandini deleted the update-kcp-proposal-disambiguating-healthcheck branch January 21, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disambiguate the term health in the KCP code/proposal
3 participants