🐛 KubeadmControlPlane should adopt v1alpha2 kubeconfig secrets #4034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/milestone v0.4.0 |
|
/retest |
wfernandes
reviewed
Dec 18, 2020
vincepri
reviewed
Dec 18, 2020
fabriziopandini
force-pushed
the
kcp-adopts-kubeconfig-secrets
branch
from
8bf0e58 to
13e8b81
Compare
|
@vincepri @wfernandes comment addressed! |
vincepri
changed the title
k8s-ci-robot
added
the
approved
|
/assign @CecileRobertMichon @detiber |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
CecileRobertMichon
approved these changes
Jan 4, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR ensures kubeconfig secrets created by v1alpha2 controllers are adopted by KCP, thus allowing periodic kubeconfig secrete re-generation preventing the expiration of the embedded client certificate.
Which issue(s) this PR fixes:
Fixes #4011