Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update Controller Runtime to v0.7.0-alpha.8 #3981

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Dec 2, 2020

Signed-off-by: Vince Prignano [email protected]

What this PR does / why we need it:
Updates controller runtime to the latest alpha version

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 2, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 2, 2020
Comment on lines +27 to +28
- "fake.NewFakeClientWithScheme is deprecated: Please use NewClientBuilder instead."
- "fake.NewFakeClient is deprecated: Please use NewClientBuilder instead."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll open an issue for this one, so it can be picked up by a contributor

@vincepri
Copy link
Member Author

vincepri commented Dec 2, 2020

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Dec 2, 2020
@fabriziopandini
Copy link
Member

/test pull-cluster-api-test-main

@fabriziopandini
Copy link
Member

lgtm pending fix to test failures (at least one does not seem a flake)
also, should we document in the v1alpha3 to v1alpha4 changes the removal of the util func ?

@vincepri
Copy link
Member Author

vincepri commented Dec 3, 2020

@fabriziopandini Yeah, was just waiting for 3976 to be merged first

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 3, 2020

@vincepri: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-apidiff-main b21d303 link /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vincepri
Copy link
Member Author

vincepri commented Dec 3, 2020

@fabriziopandini This should be good to go

@detiber
Copy link
Member

detiber commented Dec 3, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2020
@fabriziopandini
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit ca2cf1a into kubernetes-sigs:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants