Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1alpha4] Use NewClientBuilder instead of NewFakeClient #2158

Closed
sedefsavas opened this issue Dec 10, 2020 · 5 comments
Closed

[v1alpha4] Use NewClientBuilder instead of NewFakeClient #2158

sedefsavas opened this issue Dec 10, 2020 · 5 comments
Assignees
@sedefsavas
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone
v0.7.0

Comments

@sedefsavas
Copy link
Contributor

With the upgrade to Controller Runtime v0.7.x, upgrade NewFakeClient to Controller Runtime's new fake client builder

Related PRs in CAPI:
kubernetes-sigs/cluster-api#3987
kubernetes-sigs/cluster-api#3981

Following CAPI changes documented here : https://github.com/kubernetes-sigs/cluster-api/blob/master/docs/book/src/developer/providers/v1alpha3-to-v1alpha4.md
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 10, 2021
@randomvariable randomvariable added this to the v0.7.0 milestone Mar 11, 2021
@randomvariable
Copy link
Member

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 11, 2021
@randomvariable randomvariable added the kind/release-blocking Issues or PRs that need to be closed before the next release label Apr 15, 2021
@sedefsavas sedefsavas removed the kind/release-blocking Issues or PRs that need to be closed before the next release label Jun 28, 2021
@sedefsavas
Copy link
Contributor Author

/assign

@sedefsavas
Copy link
Contributor Author

This was completed.
/close

@k8s-ci-robot
Copy link
Contributor

@sedefsavas: Closing this issue.

In response to this:

This was completed.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sedefsavas sedefsavas

Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
v0.7.0
Development

No branches or pull requests
4 participants
@randomvariable @k8s-ci-robot @fejta-bot @sedefsavas