Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Remove deprecated DeleteNodeAnnotation annotation #3955

Merged
merged 1 commit into from
Nov 30, 2020
Merged

⚠️ Remove deprecated DeleteNodeAnnotation annotation #3955

merged 1 commit into from
Nov 30, 2020

Conversation

arghya88
Copy link
Contributor

Signed-off-by: Arghya Sadhu [email protected]

What this PR does / why we need it:
Remove deprecated DeleteNodeAnnotation annotation in v1alpha4
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3954

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 30, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 30, 2020
@arghya88
Copy link
Contributor Author

/cc @vincepri

vincepri
vincepri reviewed Nov 30, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @arghya88 for the PR! Let's also clean up all the test cases, given that those are already covered

controllers/machineset_delete_policy.go Outdated Show resolved Hide resolved
controllers/machineset_delete_policy.go Outdated Show resolved Hide resolved
controllers/machineset_delete_policy.go Outdated Show resolved Hide resolved
controllers/machineset_delete_policy_test.go Outdated Show resolved Hide resolved
controllers/machineset_delete_policy_test.go Outdated Show resolved Hide resolved
controllers/machineset_delete_policy_test.go Outdated Show resolved Hide resolved
controllers/machineset_delete_policy_test.go Outdated Show resolved Hide resolved
controllers/machineset_delete_policy_test.go Outdated Show resolved Hide resolved
controllers/machineset_delete_policy_test.go Outdated Show resolved Hide resolved
@vincepri
Copy link
Member

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Nov 30, 2020
@arghya88 arghya88 force-pushed the remove-DeleteNodeAnnotation branch from 85b4c7a to 061876e Compare November 30, 2020 06:30
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2020
@arghya88 arghya88 force-pushed the remove-DeleteNodeAnnotation branch 3 times, most recently from abd3318 to b2c55e2 Compare November 30, 2020 08:06
@arghya88 arghya88 force-pushed the remove-DeleteNodeAnnotation branch from b2c55e2 to f87f292 Compare November 30, 2020 08:08
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 30, 2020 •
edited
Loading

@arghya88: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-apidiff-main f87f292 link /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

fabriziopandini
fabriziopandini reviewed Nov 30, 2020
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2020
vincepri
vincepri approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2020
@vincepri vincepri mentioned this pull request Nov 30, 2020
Merged
@k8s-ci-robot k8s-ci-robot merged commit b0fd6c8 into kubernetes-sigs:master Nov 30, 2020
@arghya88 arghya88 deleted the remove-DeleteNodeAnnotation branch December 6, 2020 09:03
@furkatgofurov7 furkatgofurov7 mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@vincepri vincepri vincepri approved these changes

@benmoss benmoss Awaiting requested review from benmoss

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

Remove the DeleteNodeAnnotation (deprecated) annotation
4 participants
@arghya88 @vincepri @k8s-ci-robot @fabriziopandini