Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the DeleteNodeAnnotation (deprecated) annotation #3954

Closed
vincepri opened this issue Nov 30, 2020 · 6 comments · Fixed by #3955
Closed

Remove the DeleteNodeAnnotation (deprecated) annotation #3954

vincepri opened this issue Nov 30, 2020 · 6 comments · Fixed by #3955
Assignees
@arghya88
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v0.4

Comments

@vincepri
Copy link
Member

The following annotation has been deprecated in an earlier version, and should be removed entirely in v1alpha4

cluster-api/controllers/machineset_delete_policy.go

Lines 34 to 37 in 2dd66d6

// DeleteNodeAnnotation marks nodes that will be given priority for deletion
// when a machineset scales down. This annotation is given top priority on all delete policies.
// Deprecated: Please use DeleteMachineAnnotation instead.
DeleteNodeAnnotation = "cluster.k8s.io/delete-machine"

/kind cleanup
/milestone v0.4.0
/good-first-issue
@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

The following annotation has been deprecated in an earlier version, and should be removed entirely in v1alpha4

cluster-api/controllers/machineset_delete_policy.go

Lines 34 to 37 in 2dd66d6

// DeleteNodeAnnotation marks nodes that will be given priority for deletion
// when a machineset scales down. This annotation is given top priority on all delete policies.
// Deprecated: Please use DeleteMachineAnnotation instead.
DeleteNodeAnnotation = "cluster.k8s.io/delete-machine"

/kind cleanup
/milestone v0.4.0
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Nov 30, 2020
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 30, 2020
@vincepri
Copy link
Member Author

/help

@vincepri
Copy link
Member Author

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Nov 30, 2020
@vincepri
Copy link
Member Author

Whoever picks this up, please mark your PR as ⚠️, given that removing an exporting constant is a breaking change 😊

@arghya88
Copy link
Contributor

/assign

@arghya88
Copy link
Contributor

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Nov 30, 2020
@arghya88 arghya88 mentioned this issue Nov 30, 2020
Merged
@furkatgofurov7 furkatgofurov7 mentioned this issue Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arghya88 arghya88

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

⚠️ Remove deprecated DeleteNodeAnnotation annotation arghya88/cluster-api
3 participants
@vincepri @arghya88 @k8s-ci-robot