Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️Remove hard code manifest version and hash #3918

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

jichenjc
Copy link
Contributor

@jichenjc jichenjc commented Nov 13, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
⚠️Fixes #3505

(*clusterClient).CertManager: changed from func() CertManagerClient to func() (CertManagerClient, error)
Client.CertManager: changed from func() CertManagerClient to func() (CertManagerClient, error)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 13, 2020
@jichenjc
Copy link
Contributor Author

create this in order to see whether 0.3 CI will be triggered or not

@jichenjc jichenjc changed the title WIP: Remove hard code version and has in manifest ⚠️Remove hard code manifest version and hash Nov 13, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2020
@jichenjc
Copy link
Contributor Author

@fabriziopandini @vincepri @wfernandes @CecileRobertMichon thanks for your help
please check this is re-submit of #3908

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020
@wfernandes
Copy link
Contributor

/lgtm
@CecileRobertMichon @vincepri for approval.

@wfernandes
Copy link
Contributor

@jichenjc Could you amend the commit to Remove hard code version and hash in manifest?
That is has --> hash. Thanks

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2020
@jichenjc
Copy link
Contributor Author

@wfernandes just updated :) thanks for point out

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2020
@CecileRobertMichon
Copy link
Contributor

/approve
/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Nov 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 16, 2020

@jichenjc: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-apidiff-main 5190aef link /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vincepri
Copy link
Member

/test pull-cluster-api-test-main

@k8s-ci-robot k8s-ci-robot merged commit e6b0039 into kubernetes-sigs:master Nov 16, 2020
sedefsavas pushed a commit to sedefsavas/cluster-api that referenced this pull request Nov 19, 2020
⚠️Remove hard code manifest version and hash
sedefsavas pushed a commit to sedefsavas/cluster-api that referenced this pull request Nov 19, 2020
⚠️Remove hard code manifest version and hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants