⚠️Remove hard code manifest version and hash

[jichenjc]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
⚠️Fixes #3505

(*clusterClient).CertManager: changed from func() CertManagerClient to func() (CertManagerClient, error)
Client.CertManager: changed from func() CertManagerClient to func() (CertManagerClient, error)

[jichenjc]

this is same PR to #3707 only with different target (v0.3 vs master)

[jichenjc]

same to #3707 only difference it this target to master, not v0.3

[fabriziopandini]

thanks @jichenjc !
/lgtm

[fabriziopandini]

Uhmm for some reason, CI triggered both 0.3 and 0.4 jobs...

[fejta-bot]

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

[CecileRobertMichon]

lgtm

thank you @jichenjc for your patience and your help in getting this to the right release branch

[wfernandes]

/approve

[wfernandes]

I guess I don't have the permissions. 🤷
lgtm.
@CecileRobertMichon @fabriziopandini for approval.

[CecileRobertMichon]

/approve

[vincepri]

/approve
/lgtm
/milestone v0.4.0

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, vincepri, wfernandes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/clusterctl/OWNERS [CecileRobertMichon,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[CecileRobertMichon]

Not mergeable. Job pull-cluster-api-apidiff-release-0-3 has not succeeded.

hmm how come it's running 0.3 jobs? also shouldn't that job not be required?

[jichenjc]

I think it's because API change
And I was told last time that this change is one time (we don't need to keep it consistent ) as next time it will be ok since the API already changed after the code merge..

[jichenjc]

And I don't know why it's requesting 0.3 version CI... seems I am pulling to master

[CecileRobertMichon]

/retest

[CecileRobertMichon]

/override pull-cluster-api-apidiff-release-0-3

It looks like prow is getting triggered on 0.3 because the same commit is targeting release-0.3 in the other PR

https://prow.k8s.io/pr?query=is%3Apr+repo%3Akubernetes-sigs%2Fcluster-api+author%3Ajichenjc+head%3Abug%2F3505

[k8s-ci-robot]

@CecileRobertMichon: CecileRobertMichon unauthorized: /override is restricted to Repo administrators.

In response to this:

/override pull-cluster-api-apidiff-release-0-3

It looks like prow is getting triggered on 0.3 because the same commit is targeting release-0.3 in the other PR

https://prow.k8s.io/pr?query=is%3Apr+repo%3Akubernetes-sigs%2Fcluster-api+author%3Ajichenjc+head%3Abug%2F3505

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fabriziopandini]

/override pull-cluster-api-apidiff-release-0-3

because this job targets the v0.4.0 branch
not sure I have all the required grants...

[k8s-ci-robot]

@fabriziopandini: fabriziopandini unauthorized: /override is restricted to Repo administrators.

In response to this:

/override pull-cluster-api-apidiff-release-0-3

because this job targets the v0.4.0 branch
not sure I have all the required grants...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jichenjc]

/retest

[jichenjc]

the #3707 is closed ...
if necessary, I can resubmit the PR

[k8s-ci-robot]

@jichenjc: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-cluster-api-apidiff-main	2cd042c	link	/test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jichenjc]

#3918
I recreated the PR to avoid same commit to different branch ...

@fabriziopandini @vincepri @wfernandes @CecileRobertMichon thanks for your support