Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️capk generates kubadm config files under /run/kubeadm/ instead of /tmp #3776

Merged
merged 1 commit into from
Oct 15, 2020
Merged

⚠️capk generates kubadm config files under /run/kubeadm/ instead of /tmp #3776

merged 1 commit into from
Oct 15, 2020

Conversation

arghya88
Copy link
Contributor

@arghya88 arghya88 commented Oct 12, 2020 •
edited
Loading

What this PR does / why we need it:

cloud-init runcmd steps should not write to /tmp because of a race w/ systemd-tmpfiles-clean

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3769

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 12, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @arghya88. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 12, 2020
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 12, 2020
benmoss
benmoss suggested changes Oct 12, 2020
View reviewed changes
Copy link

@benmoss benmoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think /run/kubeadm will exist by default and so might need to be created, unlike /tmp. Have you tested these changes?

test/infrastructure/docker/cloudinit/kindadapter_test.go Outdated Show resolved Hide resolved
@benmoss
Copy link

benmoss commented Oct 12, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 12, 2020
@vincepri
Copy link
Member

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Oct 12, 2020
@arghya88
Copy link
Contributor Author

/assign @ncdc

vincepri
vincepri approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @fabriziopandini

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2020
@CecileRobertMichon
Copy link
Contributor

@arghya88 please add a PR description describing why this change is desirable

@arghya88
Copy link
Contributor Author

@CecileRobertMichon Thanks for feedback..I have added a description

@fabriziopandini
Copy link
Member

Thanks @arghya88 !
PR looks good to me! My only concern is how do we start to document v1alpha4 breaking changes like this. Should we change the PR title as :warning ?
@vincepri ^^

@arghya88
Copy link
Contributor Author

@fabriziopandini I am fine doing that if that's good enough. Have we done something else before to handle breaking change scenario?

@fabriziopandini
Copy link
Member

fabriziopandini commented Oct 13, 2020 •
edited
Loading

Renaming the PR should be enough IMO, but let's wait for a confirmation

@ncdc
Copy link
Contributor

ncdc commented Oct 13, 2020

@fabriziopandini this doesn't look like a breaking change to me?

@fabriziopandini
Copy link
Member

@ncdc this is not breaking any API, but there are users relying on the current file location for their PreKubeadmCommands, so I want to be sure they are properly informed.

@arghya88 arghya88 mentioned this pull request Oct 14, 2020
Closed
6 tasks
@arghya88
Copy link
Contributor Author

@vincepri should we then change the title of the PR to warning?

cc @fabriziopandini

@fabriziopandini
Copy link
Member

+1 to add warning and retitle in something like "capk generates kubadm config files under /run/kubeadm/ instead of /tmp"

@arghya88 arghya88 changed the title 🐛remove usage of /tmp in capbk ⚠️capk generates kubadm config files under /run/kubeadm/ instead of /tmp Oct 14, 2020
@vincepri
Copy link
Member

Thanks for marking it as a breaking change!

@vincepri
Copy link
Member

/ test pull-cluster-api-e2e-full-main

@vincepri
Copy link
Member

/test pull-cluster-api-e2e-full-main

1 similar comment
@vincepri
Copy link
Member

/test pull-cluster-api-e2e-full-main

vincepri
vincepri approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit c60ae8b into kubernetes-sigs:master Oct 15, 2020
@superbrothers superbrothers mentioned this pull request Oct 20, 2020
Closed
@arghya88 arghya88 deleted the remove-tmp branch November 30, 2020 05:09
This was referenced Jul 4, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmoss benmoss benmoss requested changes

@vincepri vincepri vincepri approved these changes

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@ncdc ncdc

@vincepri vincepri

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

CAPBK should not write to /tmp
7 participants
@arghya88 @k8s-ci-robot @benmoss @vincepri @CecileRobertMichon @fabriziopandini @ncdc