Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPBK should not write to /tmp #3769

Closed
fabriziopandini opened this issue Oct 9, 2020 · 5 comments · Fixed by #3776
Closed

CAPBK should not write to /tmp #3769

fabriziopandini opened this issue Oct 9, 2020 · 5 comments · Fixed by #3776
Assignees
@arghya88
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Milestone
v0.4

Comments

@fabriziopandini
Copy link
Member

https://cloudinit.readthedocs.io/en/latest/topics/modules.html#runcmd
the docs here say that cloud-init runcmd steps should not write to /tmp because of a race w/ systemd-tmpfiles-clean, but currently, CABPK writes to /tmp/kubeadm.yaml and /tmp/kubeadm-join-config.yaml.

Instead, we should write to someplace like /run/kubeadm

/kind bug
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 9, 2020
@fabriziopandini
Copy link
Member Author

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Oct 9, 2020
@vincepri
Copy link
Member

vincepri commented Oct 9, 2020

/help

@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 9, 2020
@arghya88
Copy link
Contributor

/assign

@arghya88 arghya88 mentioned this issue Oct 12, 2020
Merged
@arghya88
Copy link
Contributor

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arghya88 arghya88

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

⚠️capk generates kubadm config files under /run/kubeadm/ instead of /tmp arghya88/cluster-api
4 participants
@vincepri @fabriziopandini @arghya88 @k8s-ci-robot