🐛 Fix kustomize_substitutions #3378
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
Tiltfile
Outdated
| substitutions = settings.get("kustomize_substitutions", {}) | ||
| for substitution in substitutions: | ||
| value = substitutions[substitution] | ||
| yaml = yaml.replace("${" + substitution + "}", value) | ||
| os.environ[substitution] = substitutions[substitution] |
There was a problem hiding this comment.
can use os.environ.update(substitutions) to simplify a bit
There was a problem hiding this comment.
Thanks, I was looking at Tilt's docs on the Starlark syntax and didn't see that. Will make the change.
|
didn't realize you self assigned, was about to open the same: https://github.com/kubernetes-sigs/cluster-api/compare/master...alexeldeib:ace/tiltish?expand=1#diff-1a474bf970407efc3332970120c1a429R195 |
|
/milestone v0.3.8 |
|
/test pull-cluster-api-e2e |
Copy kustomize_substitutions into os.environ before calling kustomize + envsubst to ensure the values are available to envsubst. Signed-off-by: Andy Goldstein <[email protected]>
ncdc
force-pushed
the
fix-tilt-kustomize-substitutions
branch
from
0f55510 to
d040103
Compare
|
Updated, PTAL! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
What this PR does / why we need it:
Copy kustomize_substitutions into os.environ before calling kustomize +
envsubst to ensure the values are available to envsubst.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3375