Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kustomize_substitutions in tilt-settings.json is broken #3375

Closed
ncdc opened this issue Jul 22, 2020 · 2 comments · Fixed by #3378
Closed

kustomize_substitutions in tilt-settings.json is broken #3375

ncdc opened this issue Jul 22, 2020 · 2 comments · Fixed by #3378
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Milestone

Comments

@ncdc
Copy link
Contributor

ncdc commented Jul 22, 2020

What steps did you take and what happened:

  1. Try to use kustomize_substitutions for variables that you do not set as environment variables
  2. These placeholders are replaced with the empty string

What did you expect to happen:

  1. Successful replacement from kustomize_substitutions from tilt-settings.json

Anything else you would like to add:
The change to use kustomize with envsubst (#3361) accidentally broke this. We can maybe try to copy all the substitutions into os.environ before running kustomize.

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 22, 2020
@vincepri
Copy link
Member

/milestone v0.3.x

Chatting with @wfernandes, I'd like to see a clusterctl generic command that

  • Takes any files as input, uses our internal envsubst implementation, and prints out the result.
  • It has a --variables flag to print out all the variables
    • This can be used to look at the defaults, print out all the required variables

@k8s-ci-robot k8s-ci-robot added this to the v0.3.x milestone Jul 22, 2020
@ncdc
Copy link
Contributor Author

ncdc commented Jul 22, 2020

/assign
/lifecycle active
FYI @alexeldeib

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants