Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃‍♂️ Switch clusterctl logging to stderr #3124

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

benmoss
Copy link

@benmoss benmoss commented Jun 1, 2020

What this PR does / why we need it:
This lets us log warnings like when overrides are being used without interfering with the ability to pipe to kubectl.

Before you'd get:

clusterctl config cluster bmo --kubernetes-version v1.17.3 --control-plane-machine-count=1 -v 5  | k apply -f-
error: error parsing STDIN: error converting YAML to JSON: yaml: line 2: mapping values are not allowed in this context

Now you get:

bin/clusterctl config cluster bmo --kubernetes-version v1.17.3 --control-plane-machine-count=1 -v 5  | k apply -f-
No default config file available
Fetching File="cluster-template.yaml" Provider="infrastructure-aws" Version="v0.5.3"
cluster.cluster.x-k8s.io/bmo created
awscluster.infrastructure.cluster.x-k8s.io/bmo created
kubeadmcontrolplane.controlplane.cluster.x-k8s.io/bmo-control-plane created
awsmachinetemplate.infrastructure.cluster.x-k8s.io/bmo-control-plane unchanged
machinedeployment.cluster.x-k8s.io/bmo-md-0 created
awsmachinetemplate.infrastructure.cluster.x-k8s.io/bmo-md-0 created
kubeadmconfigtemplate.bootstrap.cluster.x-k8s.io/bmo-md-0 unchanged

Which issue(s) this PR fixes
Fixes #2713

- Always log overrides
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 1, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 1, 2020
@CecileRobertMichon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2020
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @fabriziopandini @wfernandes
/milestone v0.3.7
/retitle 🏃‍♂️ Switch clusterctl logging to stderr

@k8s-ci-robot k8s-ci-robot added this to the v0.3.7 milestone Jun 1, 2020
@k8s-ci-robot k8s-ci-robot changed the title ✨ Switch clusterctl logging to stderr 🏃‍♂️ Switch clusterctl logging to stderr Jun 1, 2020
@benmoss
Copy link
Author

benmoss commented Jun 1, 2020

one man's chore is another man's feature 🤷

@vincepri
Copy link
Member

vincepri commented Jun 1, 2020

@benmoss Just going with the guidelines, ✨ will go in New Features section

@fabriziopandini
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benmoss, fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2020
@wfernandes
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 3ac3514 into kubernetes-sigs:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[clusterctl] log when using overrides for clusterctl
6 participants