-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃♂️ Switch clusterctl logging to stderr #3124
Conversation
- Always log overrides
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign @fabriziopandini @wfernandes
/milestone v0.3.7
/retitle 🏃♂️ Switch clusterctl logging to stderr
one man's chore is another man's feature 🤷 |
@benmoss Just going with the guidelines, ✨ will go in New Features section |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benmoss, fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
This lets us log warnings like when overrides are being used without interfering with the ability to pipe to
kubectl
.Before you'd get:
Now you get:
Which issue(s) this PR fixes
Fixes #2713