Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clusterctl log output should be printed to stderr #2963

Closed
wfernandes opened this issue Apr 24, 2020 · 6 comments
Closed

clusterctl log output should be printed to stderr #2963

wfernandes opened this issue Apr 24, 2020 · 6 comments
Labels
area/clusterctl Issues or PRs related to clusterctl help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@wfernandes
Copy link
Contributor

What steps did you take and what happened:
When I print out higher verbosity logs from clusterctl for example clusterctl config cluster -v5 test -i aws, it prints out the logs and output to stdout. So piping the output such as clusterctl config cluster -v5 test -i aws | kubectl apply -f - doesn't work.

What did you expect to happen:
I'd expect the logs to be printed out to stderr which is a more ubiquitous behavior I believe.

/kind bug
/area clusterctl
/help

@k8s-ci-robot
Copy link
Contributor

@wfernandes:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

What steps did you take and what happened:
When I print out higher verbosity logs from clusterctl for example clusterctl config cluster -v5 test -i aws, it prints out the logs and output to stdout. So piping the output such as clusterctl config cluster -v5 test -i aws | kubectl apply -f - doesn't work.

What did you expect to happen:
I'd expect the logs to be printed out to stderr which is a more ubiquitous behavior I believe.

/kind bug
/area clusterctl
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/clusterctl Issues or PRs related to clusterctl help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 24, 2020
@fabriziopandini
Copy link
Member

The same should apply to cluster config provider -o yaml

@vincepri
Copy link
Member

/milestone v0.3.x
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added this to the v0.3.x milestone Apr 29, 2020
@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Apr 29, 2020
@jodavis-suse
Copy link

Easy one liner to intentionally break and create both debug and error log output (by using clusterctl without a provider):
clusterctl config cluster failcluster -v 5 1>stdout.txt 2>stderr.txt

@wfernandes
Copy link
Contributor Author

I just tested this on the current clusterctl cli and it seems to work.

clusterctl version: &version.Info{Major:"0", Minor:"3", GitVersion:"v0.3.7-alpha.0.38-303f4923517c42-dirty", GitCommit:"303f4923517c42a0fad9d40935eafcc151e0f288", GitTreeState:"dirty", BuildDate:"2020-06-24T17:55:51Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"darwin/amd64"}

It seems that this got fixed as part of PR #3124

/close

@k8s-ci-robot
Copy link
Contributor

@wfernandes: Closing this issue.

In response to this:

I just tested this on the current clusterctl cli and it seems to work.

clusterctl version: &version.Info{Major:"0", Minor:"3", GitVersion:"v0.3.7-alpha.0.38-303f4923517c42-dirty", GitCommit:"303f4923517c42a0fad9d40935eafcc151e0f288", GitTreeState:"dirty", BuildDate:"2020-06-24T17:55:51Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"darwin/amd64"}

It seems that this got fixed as part of PR #3124

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterctl Issues or PRs related to clusterctl help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

5 participants