Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃Minor fix for MachinePool kubebuilder rbac tag #3055

Closed
wants to merge 1 commit into from

Conversation

sedefsavas
Copy link

What this PR does / why we need it:
This PR removes exp.infrastructure.cluster.x-k8s.io from machine pool rbac. Should be exp.cluster.x-k8s.io instead.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sedefsavas
To complete the pull request process, please assign ncdc
You can assign the PR to them by writing /assign @ncdc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from detiber and vincepri May 13, 2020 15:53
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 13, 2020
@sedefsavas
Copy link
Author

/assign @vincepri

@vincepri
Copy link
Member

/hold

I think it should be both, because MachinePool implementations might refer to experiments in infrastructure provider, like CAPZ

@CecileRobertMichon can you confirm?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2020
@CecileRobertMichon
Copy link
Contributor

I think it should be both, because MachinePool implementations might refer to experiments in infrastructure provider, like CAPZ

Correct, see #2959. cc @devigned

@sedefsavas
Copy link
Author

Makes sense, didn't think about providers. Thanks!

@sedefsavas sedefsavas closed this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants