✨ grant rbac access to experimental infra api group #2959
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
devigned
changed the title
k8s-ci-robot
added
the
size/S
devigned
changed the title
devigned
changed the title
devigned
changed the title
| @@ -28,6 +28,20 @@ rules: | |||
| - patch | |||
| - update | |||
| - watch | |||
| - apiGroups: | |||
| - bootstrap.cluster.x-k8s.io | |||
| - exp.infrastructure.cluster.x-k8s.io | |||
There was a problem hiding this comment.
should this be added to the apiGroups above instead?
There was a problem hiding this comment.
These should be automatically generated
There was a problem hiding this comment.
why are bootstrap.cluster.x-k8s.io and infrastructure.cluster.x-k8s.io duplicated then?
There was a problem hiding this comment.
I haven't looked at the controller-tools in a while, but IIRC it's because there is two different kubebuilder directives which the code can't dedupe
There was a problem hiding this comment.
not allowing all resources for the experimental group can be an extra gate when / if needed. LGTM as per the existing exp.cluster.x-k8s.io.
also this ClusterRole file seems quite messy, indeed.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devigned, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
This grants CAPI access to
exp.infrastructure.cluster.x-k8s.ioapi group. Theexp.infrastructure.cluster.x-k8s.ioapi group corresponds to experimental features in the infrastructure provider and was patterned afterexp.cluster.x-k8s.io. This will be useful for supportingMachinePooland other experimental implementations in infra providers.Related: