Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Update MachineDeployment controller image in docs #2878

Merged
merged 1 commit into from
Apr 8, 2020
Merged

🐛 Update MachineDeployment controller image in docs #2878

merged 1 commit into from
Apr 8, 2020

Conversation

prankul88
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2867

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 8, 2020
JoelSpeed
JoelSpeed reviewed Apr 8, 2020
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

While reviewing, I also noticed there is a typo in the MachineDeployment image, it states at the top that the flow is for the MachineSet controller, should probably fix that too at some point

cluster-api/docs/book/src/images/cluster-admission-machinedeployment-controller.plantuml

Line 4 in 597836d

:MachineSet controller;

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2020
@prankul88
Copy link
Contributor Author

@JoelSpeed Should I update it here?

@JoelSpeed
Copy link
Contributor

Up to you, if you wouldn't mind doing so then that's great, otherwise we can follow up another time

@prankul88 prankul88 force-pushed the update-machinedeployment-doc branch from 597836d to 3f55470 Compare April 8, 2020 10:26
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2020
@prankul88
Copy link
Contributor Author

@JoelSpeed Have updated. PTAL

JoelSpeed
JoelSpeed reviewed Apr 8, 2020
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thanks! Would you mind also updating the SVG version of the same image for consistency please?

@prankul88
Copy link
Contributor Author

@JoelSpeed Sorry forgot about that. Updating..

@prankul88 prankul88 force-pushed the update-machinedeployment-doc branch from 3f55470 to 662e2ec Compare April 8, 2020 10:38
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 8, 2020
JoelSpeed
JoelSpeed reviewed Apr 8, 2020
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for updating it :)

@prankul88
Copy link
Contributor Author

@JoelSpeed Done. Please see if anything needs to be updated

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2020
vincepri
vincepri approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prankul88, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit b1b3520 into kubernetes-sigs:master Apr 8, 2020
@vincepri
Copy link
Member

vincepri commented Apr 8, 2020

/milestone v0.3.4

@k8s-ci-robot k8s-ci-robot added this to the v0.3.4 milestone Apr 8, 2020
@prankul88 prankul88 deleted the update-machinedeployment-doc branch April 23, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@vincepri vincepri vincepri approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.4
Development

Successfully merging this pull request may close these issues.

Book's MachineDeployment page shows MachineSet controller flow
4 participants
@prankul88 @JoelSpeed @k8s-ci-robot @vincepri