Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Book's MachineDeployment page shows MachineSet controller flow #2867

Closed
vincepri opened this issue Apr 6, 2020 · 2 comments · Fixed by #2878
Closed

Book's MachineDeployment page shows MachineSet controller flow #2867

vincepri opened this issue Apr 6, 2020 · 2 comments · Fixed by #2878
Assignees
@prankul88
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.
Milestone
v0.3

Comments

@vincepri
Copy link
Member

vincepri commented Apr 6, 2020

This page https://cluster-api.sigs.k8s.io/developer/architecture/controllers/machine-deployment.html shows the incorrect flow (MachineSet), instead of the MachineDeployment one.

/kind documentation
/help
/milestone v0.3.x
@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

This page https://cluster-api.sigs.k8s.io/developer/architecture/controllers/machine-deployment.html shows the incorrect flow (MachineSet), instead of the MachineDeployment one.

/kind documentation
/help
/milestone v0.3.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v0.3.x milestone Apr 6, 2020
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 6, 2020
@prankul88
Copy link
Contributor

/assign

@prankul88 prankul88 mentioned this issue Apr 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prankul88 prankul88

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Milestone
v0.3
Development

Successfully merging a pull request may close this issue.

🐛 Update MachineDeployment controller image in docs prankul88/cluster-api
3 participants
@vincepri @k8s-ci-robot @prankul88