Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃 [e2e] clusterctl e2e config #2819

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions test/framework/clusterctl/clusterctl_config.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
// +build e2e

/*
Copyright 2020 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package clusterctl

import (
"io/ioutil"

. "github.com/onsi/gomega"

"sigs.k8s.io/yaml"
)

// Provide helpers for working with the clusterctl config file.

// clusterctlConfig defines the content of the clusterctl config file.
// The main responsibility for this structure is to point clusterctl to the local repository that should be used for E2E tests.
type clusterctlConfig struct {
Path string
Values map[string]interface{}
}

// providerConfig mirrors the clusterctl config.Provider interface and allows serialization of the corresponding info into a clusterctl config file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it should mirror the interface should we do something like var _ config.Provider = &providerConfig{} as a check.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not work, because the interface implements methods, while here we are required to implement Field to get serialization to work

type providerConfig struct {
Name string `json:"name,omitempty"`
URL string `json:"url,omitempty"`
Type string `json:"type,omitempty"`
}

// write writes a clusterctl config file to disk.
func (c *clusterctlConfig) write() {
data, err := yaml.Marshal(c.Values)
Expect(err).ToNot(HaveOccurred(), "Failed to convert to yaml the clusterctl config file")

Expect(ioutil.WriteFile(c.Path, data, 0755)).To(Succeed(), "Failed to write the clusterctl config file")
}
Loading