-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃 [e2e] clusterctl e2e config #2819
Merged
k8s-ci-robot
merged 2 commits into
kubernetes-sigs:master
from
fabriziopandini:add-clusterctl-e2e-config
Apr 6, 2020
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
// +build e2e | ||
|
||
/* | ||
Copyright 2020 The Kubernetes Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package clusterctl | ||
|
||
import ( | ||
"io/ioutil" | ||
|
||
. "github.com/onsi/gomega" | ||
|
||
"sigs.k8s.io/yaml" | ||
) | ||
|
||
// Provide helpers for working with the clusterctl config file. | ||
|
||
// clusterctlConfig defines the content of the clusterctl config file. | ||
// The main responsibility for this structure is to point clusterctl to the local repository that should be used for E2E tests. | ||
type clusterctlConfig struct { | ||
Path string | ||
Values map[string]interface{} | ||
} | ||
|
||
// providerConfig mirrors the clusterctl config.Provider interface and allows serialization of the corresponding info into a clusterctl config file. | ||
type providerConfig struct { | ||
Name string `json:"name,omitempty"` | ||
URL string `json:"url,omitempty"` | ||
Type string `json:"type,omitempty"` | ||
} | ||
|
||
// write writes a clusterctl config file to disk. | ||
func (c *clusterctlConfig) write() { | ||
data, err := yaml.Marshal(c.Values) | ||
Expect(err).ToNot(HaveOccurred(), "Failed to convert to yaml the clusterctl config file") | ||
|
||
Expect(ioutil.WriteFile(c.Path, data, 0755)).To(Succeed(), "Failed to write the clusterctl config file") | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it should mirror the interface should we do something like
var _ config.Provider = &providerConfig{}
as a check.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not work, because the interface implements methods, while here we are required to implement Field to get serialization to work