🏃 [e2e] clusterctl e2e config #2819
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/assign @vincepri |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
|
||
| "github.com/pkg/errors" | ||
| clusterctlv1 "sigs.k8s.io/cluster-api/cmd/clusterctl/api/v1alpha3" | ||
| clusterctlconfig "sigs.k8s.io/cluster-api/cmd/clusterctl/client/config" |
There was a problem hiding this comment.
May want to rename this as there is a clusterctlConfig type in test/framework/clusterctl/clusterctl_config.go
There was a problem hiding this comment.
this is an import from the clusterctl library, so the name makes sense for me because it uses the same root of e.g. clusterctlv1. Instead IMO everything under test/framework/clusterctl should be reported as testclusterctl, but this is not the case.
But if you have a better suggestion happy to change this
|
reviewing |
| Values map[string]interface{} | ||
| } | ||
|
|
||
| // providerConfig mirrors the clusterctl config.Provider interface and allows serialization of the corresponding info into a clusterctl config file. |
There was a problem hiding this comment.
Since it should mirror the interface should we do something like var _ config.Provider = &providerConfig{} as a check.
There was a problem hiding this comment.
this should not work, because the interface implements methods, while here we are required to implement Field to get serialization to work
|
@wfernandes @sedefsavas thanks for the feedback! |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
What this PR does / why we need it:
This PR extends the e2e framework by adding support for a configuration file designed for e2e tests based on clusterctl/ready to run on different infrastructure providers.
The PR includes also a utility for creating a local clusterctl repository that contains the providers defined in the e2e configuration and a clusterctl config file to make clusterctl to use this repository.
Most notably:
Which issue(s) this PR fixes:
xref #2753
xref #2637
xref #2636