Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Etcd should talk to leader when moving leadership #2726

Merged
merged 1 commit into from
Mar 19, 2020
Merged

🐛 Etcd should talk to leader when moving leadership #2726

merged 1 commit into from
Mar 19, 2020

Conversation

vincepri
Copy link
Member

Signed-off-by: Vince Prignano [email protected]

What this PR does / why we need it:
/assign @chuckha

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2020
@vincepri
Copy link
Member Author

/milestone v0.3.2

@k8s-ci-robot k8s-ci-robot added this to the v0.3.2 milestone Mar 19, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 19, 2020
@k8s-ci-robot k8s-ci-robot requested review from justinsb and ncdc March 19, 2020 16:58
@chuckha
Copy link
Contributor

chuckha commented Mar 19, 2020

/cc @rudoi

@k8s-ci-robot k8s-ci-robot requested a review from rudoi March 19, 2020 16:59
@chuckha
Copy link
Contributor

chuckha commented Mar 19, 2020

/lgtm

this will unblock the current failure, i'll clean up this function tho as the logic is a little bit confusing to follow

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2020
@vincepri
Copy link
Member Author

Tested on a running AWS cluster, it immediately unblocked upgrades

@k8s-ci-robot
Copy link
Contributor

@vincepri: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-capd-e2e 5c7ff07 link /test pull-cluster-api-capd-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 337800f into kubernetes-sigs:master Mar 19, 2020
@vincepri vincepri mentioned this pull request Mar 19, 2020
Closed
@Xenwar Xenwar mentioned this pull request Mar 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@ncdc ncdc Awaiting requested review from ncdc

@rudoi rudoi Awaiting requested review from rudoi

Assignees

@chuckha chuckha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@vincepri @k8s-ci-robot @chuckha