Skip to content

Commit

Permalink
Merge pull request #2726 from vincepri/use-leader-client
Browse files Browse the repository at this point in the history
🐛 Etcd should talk to leader when moving leadership
  • Loading branch information
k8s-ci-robot authored Mar 19, 2020
2 parents 50b8d49 + 5c7ff07 commit 337800f
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions controlplane/kubeadm/internal/workload_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,12 @@ func (w *Workload) ForwardEtcdLeadership(ctx context.Context, machine *clusterv1
return nil
}

// Move the etcd client to the current leader, which in this case is the machine we're about to delete.
etcdClient, err = w.etcdClientGenerator.forNode(ctx, machine.Status.NodeRef.Name)
if err != nil {
return errors.Wrap(err, "failed to create etcd Client")
}

// If we don't have a leader candidate, move the leader to the next available machine.
if leaderCandidate == nil || leaderCandidate.Status.NodeRef == nil {
for _, member := range members {
Expand Down

0 comments on commit 337800f

Please sign in to comment.