Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Fix the links in the quickstart #2704

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

chuckha
Copy link
Contributor

@chuckha chuckha commented Mar 18, 2020

Signed-off-by: Chuck Ha [email protected]

What this PR does / why we need it:
This PR makes it less likely we will get 404s in our book.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #2703

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 18, 2020
@chuckha
Copy link
Contributor Author

chuckha commented Mar 18, 2020

cc @sbueringer

@sbueringer
Copy link
Member

sbueringer commented Mar 18, 2020

Thx for the info.

/lgtm

for now. I'll remove the link to OpenStack in this way anyway in this PR #2683

But this will take a few days until Openstack v0.3.0 is released

(But I I'm not a reviewer here :))

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2020
@chuckha
Copy link
Contributor Author

chuckha commented Mar 18, 2020

/test pull-cluster-api-verify

@k8s-ci-robot k8s-ci-robot merged commit 73315ff into kubernetes-sigs:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants