Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 update OpenStack prerequisites in the ClusterAPI book #2683

Merged
merged 1 commit into from
Mar 23, 2020
Merged

📖 update OpenStack prerequisites in the ClusterAPI book #2683

merged 1 commit into from
Mar 23, 2020

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Mar 15, 2020 •
edited
Loading

What this PR does / why we need it:
Updates the OpenStack prereqs in the ClusterAPI book for v1alpha3

Is the book currently deployed from master?

WIP because those 2 PRs must be merged first:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2020
@sbueringer sbueringer mentioned this pull request Mar 15, 2020
Merged
@sbueringer sbueringer closed this Mar 15, 2020
@sbueringer sbueringer force-pushed the pr-update-openstack-book-doc branch from 1641d10 to f11383e Compare March 15, 2020 11:13
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2020
@sbueringer sbueringer reopened this Mar 15, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2020
@sbueringer sbueringer mentioned this pull request Mar 18, 2020
Merged
@sbueringer sbueringer mentioned this pull request Mar 18, 2020
Merged
@sbueringer
Copy link
Member Author

/retest

@sbueringer sbueringer mentioned this pull request Mar 19, 2020
Merged
3 tasks
@sbueringer sbueringer force-pushed the pr-update-openstack-book-doc branch 4 times, most recently from d42c538 to 410ae7a Compare March 22, 2020 06:37
@sbueringer sbueringer changed the title [WIP] 📖 update OpenStack prerequisites in the ClusterAPI book 📖 update OpenStack prerequisites in the ClusterAPI book Mar 22, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2020
@sbueringer
Copy link
Member Author

/assign @vincepri
/assign @detiber

@sbueringer
Copy link
Member Author

/test all

@vincepri
Copy link
Member

lgtm pending squash

@sbueringer sbueringer force-pushed the pr-update-openstack-book-doc branch from 434b048 to 36c2d6f Compare March 23, 2020 15:12
@sbueringer
Copy link
Member Author

lgtm pending squash

squash done

@sbueringer
Copy link
Member Author

/retest

vincepri
vincepri approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/milestone v0.3.3

@k8s-ci-robot k8s-ci-robot added this to the v0.3.3 milestone Mar 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2020
@detiber
Copy link
Member

detiber commented Mar 23, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit ba22259 into kubernetes-sigs:master Mar 23, 2020
@sbueringer sbueringer deleted the pr-update-openstack-book-doc branch March 23, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidekazuna hidekazuna hidekazuna left review comments

@detiber detiber detiber left review comments

@vincepri vincepri vincepri approved these changes

@moshloop moshloop Awaiting requested review from moshloop

@randomvariable randomvariable Awaiting requested review from randomvariable

Assignees

@detiber detiber

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.3
Development

Successfully merging this pull request may close these issues.
5 participants
@sbueringer @vincepri @k8s-ci-robot @detiber @hidekazuna