🏃KCP: Migrate from flags to pflags

[sedefsavas]

What this PR does / why we need it:
This PR move KCP flags to pflags for consistency with the rest of the code base.

[k8s-ci-robot]

Hi @sedefsavas. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[detiber]

/ok-to-test
/lgtm

[vincepri]

/approve
/milestone v0.3.1

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vincepri]

/test pull-cluster-api-verify

[vincepri]

@sedefsavas can you rebase on master?

[sedefsavas]

@vincepri
Rebased but still getting the same error:

docs/book/src/developer/providers/implementers-guide/building_running_and_testing.md
	ERROR	https://cluster-api.sigs.k8s.io/tasks/installation.html#install-cluster-api
		Not Found (HTTP error 404)

That link is actually missing.

[vincepri]

@sedefsavas do you mind checking if the link is actually going 404 locally?

[detiber]

@vincepri I think the error is related to the removal of the separate Installation doc with it being incorporated into the quick start

[vincepri]

Yeah, but it should have been caught in the other PR, I'm trying to understand if this is a false positive or if the verification job needs to be changed somehow

[sedefsavas]

Yeah, but it should have been caught in the other PR, I'm trying to understand if this is a false positive or if the verification job needs to be changed somehow

Yes, tasks/installation.html is missing locally too.

It is moved in the previous PR merged:
5bb2219

[sedefsavas]

/retest

[k8s-ci-robot]

@sedefsavas: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-cluster-api-capd-e2e	1459279	link	/test pull-cluster-api-capd-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[vincepri]

/lgtm