Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KCP: expose additional LeaderElection configuration as flags #2653

Closed
rudoi opened this issue Mar 12, 2020 · 6 comments · Fixed by #2664
Closed

KCP: expose additional LeaderElection configuration as flags #2653

rudoi opened this issue Mar 12, 2020 · 6 comments · Fixed by #2664
Assignees
Labels
area/control-plane Issues or PRs related to control-plane lifecycle management kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.

Comments

@rudoi
Copy link
Contributor

rudoi commented Mar 12, 2020

Background

The default leader election configuration options are:

  • LeaseDuration: 15 seconds
  • RenewDeadline: 10 seconds
  • RetryPeriod: 2 seconds

These values are quite small, but reasonable for most controllers. However, when the KCP controller is facilitating an upgrade, there is a legitimate risk that API server connectivity is disrupted (see #2652). On a self-managed cluster, because of these small values, this disruption can result in the controller losing track of its leader election. This causes the controller pod to crash.

The Request

We (as self-managed cluster users) would like to be able to configure these parameters. Flags seem reasonable!

/kind feature
/cc @vincepri @mytunguyen @sethp-nr

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 12, 2020
@rudoi
Copy link
Contributor Author

rudoi commented Mar 12, 2020

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Mar 12, 2020
@rudoi
Copy link
Contributor Author

rudoi commented Mar 12, 2020

just waiting for #2656 and then i'll get going on this

@rudoi
Copy link
Contributor Author

rudoi commented Mar 12, 2020

/assign @trutx

@k8s-ci-robot
Copy link
Contributor

@rudoi: GitHub didn't allow me to assign the following users: trutx.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @trutx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trutx
Copy link
Contributor

trutx commented Mar 12, 2020

I can pick this up if you don't mind

@rudoi
Copy link
Contributor Author

rudoi commented Mar 12, 2020

let's try this again!

/assign @trutx

@vincepri vincepri added the area/control-plane Issues or PRs related to control-plane lifecycle management label Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Issues or PRs related to control-plane lifecycle management kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants