🏃 Fix flake test in KCP webhook TestPaths #2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
vincepri
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/milestone v0.3.x |
k8s-ci-robot
added
the
size/XS
|
@wfernandes do you have time to review this? |
|
/milestone v0.3.0 moving to v0.3.0 given that it could block or slow down other PRs |
wfernandes
reviewed
Mar 6, 2020
| @@ -639,7 +639,9 @@ func TestPaths(t *testing.T) { | |||
| for _, tt := range tests { | |||
| t.Run(tt.name, func(t *testing.T) { | |||
| g := NewWithT(t) | |||
| g.Expect(paths(tt.path, tt.diff)).To(Equal(tt.expected)) | |||
| for _, path := range paths(tt.path, tt.diff) { | |||
| g.Expect(path).To(BeElementOf(tt.expected)) | |||
There was a problem hiding this comment.
I'm sure this works but did you try ConsistOf?
Signed-off-by: Vince Prignano <[email protected]>
chuckha
approved these changes
Mar 9, 2020
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
Attempts to fix a flake due to ordering not being stable.
Example flake: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/2581/pull-cluster-api-test/1236061219702444033
/assign @chuckha