Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Allow KCP spec.version to be mutable #2582

Merged
merged 1 commit into from
Mar 9, 2020
Merged

🐛 Allow KCP spec.version to be mutable #2582

merged 1 commit into from
Mar 9, 2020

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Mar 6, 2020

Signed-off-by: Vince Prignano [email protected]

What this PR does / why we need it:
/assign @chuckha @ncdc @detiber
/milestone v0.3.0

@k8s-ci-robot k8s-ci-robot added this to the v0.3.0 milestone Mar 6, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2020
@ncdc
Copy link
Contributor

ncdc commented Mar 7, 2020

2 things:

  1. Let's make sure we have a test case for this?
  2. We need to sort the expected & actual strings in the TestPaths to avoid flakes (since we're ranging on map keys)

@vincepri
Copy link
Member Author

vincepri commented Mar 7, 2020

@ncdc Flake is being fixed in #2583

@vincepri vincepri force-pushed the allow-version-change branch from 9165f44 to 992f410 Compare March 8, 2020 16:58
@chuckha
Copy link
Contributor

chuckha commented Mar 9, 2020 •
edited
Loading

+1 to adding a test case. We aren't explicitly checking that version is allowed to change in the update tests right now.

edit: nvm there is one there

@chuckha
Copy link
Contributor

chuckha commented Mar 9, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9db9537 into kubernetes-sigs:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@detiber detiber Awaiting requested review from detiber

Assignees

@ncdc ncdc

@chuckha chuckha

@detiber detiber

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@vincepri @k8s-ci-robot @ncdc @chuckha @detiber