-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Etcd version #2579
✨ Etcd version #2579
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v0.3.0 |
waiting for rebase, code changes related to the configmap are 👍 |
Signed-off-by: Chuck Ha <[email protected]>
/hold cancel rebased |
@chuckha should we add some unit tests? I known it’s eod for you, I can pick them up after we merge this |
sure, i can add some |
@vincepri actually yeah, if you don't mind. I can do them on Monday as well if you don't get to 'em today 👍 |
if err != nil { | ||
return err | ||
} | ||
config := &kubeadmConfig{ConfigMap: kubeadmConfigMap} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we compare first the values in the map vs the ones we want to set before issuing the update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do a follow-up here as well
/lgtm |
/holdDepends on #2553What this PR does / why we need it:
This PR allows KCP to keep track of the local etcd version and manage the value stored in the kubeadm config map. The result is that when an upgrade is performed it will use the value found in the kubeadm config map.
The workflow I tested with was:
k8s.gcr.io/etcd
(gcloud container images list-tags k8s.gcr.io/etcd
)3.3.17-0
.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2543