Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KCP: Handle etcd upgrades #2543

Closed
vincepri opened this issue Mar 5, 2020 · 5 comments · Fixed by #2579
Closed

KCP: Handle etcd upgrades #2543

vincepri opened this issue Mar 5, 2020 · 5 comments · Fixed by #2579
Assignees
@chuckha
Labels
area/control-plane Issues or PRs related to control-plane lifecycle management kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
v0.3.0

Comments

@vincepri
Copy link
Member

vincepri commented Mar 5, 2020

This issue is a follow-up to #2226.

  • relax the validating webhook to allow mutations to the etcd image details in KCP spec
  • add code that syncs the etcd image details from the KCP to the kubeadm-config ConfigMap in the workload cluster

/kind feature
/milestone v0.3.0
/priority critical-urgent
/area control-plane
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 5, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.3.0 milestone Mar 5, 2020
@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/control-plane Issues or PRs related to control-plane lifecycle management labels Mar 5, 2020
@vincepri
Copy link
Member Author

vincepri commented Mar 5, 2020

cc @chuckha

@chuckha chuckha self-assigned this Mar 5, 2020
@chuckha
Copy link
Contributor

chuckha commented Mar 5, 2020

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Mar 5, 2020
@chuckha chuckha mentioned this issue Mar 5, 2020
Merged
@chuckha
Copy link
Contributor

chuckha commented Mar 6, 2020

reminder to self: need to ensure that if external is set and local gets updated that should fail validation

@vincepri
Copy link
Member Author

vincepri commented Mar 6, 2020

@chuckha want me to open a different issue for that?

@chuckha chuckha mentioned this issue Mar 6, 2020
Merged
@chuckha
Copy link
Contributor

chuckha commented Mar 6, 2020

got it, #2580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuckha chuckha

Labels
area/control-plane Issues or PRs related to control-plane lifecycle management kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

✨ Etcd version chuckha/cluster-api
3 participants
@chuckha @vincepri @k8s-ci-robot