Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kubeadm control plane] ensure etcd settings are correct #2580

Closed
chuckha opened this issue Mar 6, 2020 · 3 comments · Fixed by #2598
Closed

[kubeadm control plane] ensure etcd settings are correct #2580

chuckha opened this issue Mar 6, 2020 · 3 comments · Fixed by #2598
Assignees
@chuckha @nader-ziada
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v0.3

Comments

@chuckha
Copy link
Contributor

chuckha commented Mar 6, 2020

If a user uses the external setting of etcd we need to make sure changes to the local etcd don't validate in the web hook because defining both external and local doesn't make any sense as far as kubeadm config is concerned

/kind bug
/assign
/priority important-longterm
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Mar 6, 2020
@chuckha chuckha mentioned this issue Mar 6, 2020
Closed
@vincepri
Copy link
Member

vincepri commented Mar 6, 2020

/help
/milestone v0.3.x

Although it would be nice to have in v0.3.0, maybe @nader-ziada or @gab-satchi are interested in helping here?

@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
/milestone v0.3.x

Although it would be nice to have in v0.3.0, maybe @nader-ziada or @gab-satchi are interested in helping here?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v0.3.x milestone Mar 6, 2020
@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 6, 2020
@nader-ziada
Copy link
Contributor

I. can work on it, but not sure whats needed yet

/assign

@nader-ziada nader-ziada mentioned this issue Mar 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuckha chuckha

@nader-ziada nader-ziada

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v0.3
Development

Successfully merging a pull request may close this issue.

🐛validation for not having both local and external etcd in control plane nader-ziada/cluster-api
4 participants
@chuckha @vincepri @nader-ziada @k8s-ci-robot