Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Update controller images in book #2529

Merged
merged 1 commit into from
Mar 4, 2020
Merged

📖 Update controller images in book #2529

merged 1 commit into from
Mar 4, 2020

Conversation

chuckha
Copy link
Contributor

@chuckha chuckha commented Mar 4, 2020

Signed-off-by: Chuck Ha [email protected]

  1. The makefile only generates .pngs so I've changed references to .png and removed the .svgs.
  2. This fixes a typo in the kubeadm control plane flow chart
  3. Fix the paths after the controllers got nested another level down.

Fixes #2528
Fixes #2143

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 4, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2020
vincepri
vincepri approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @detiber ?

/milestone v0.3.0-rc.3

@k8s-ci-robot k8s-ci-robot added this to the v0.3.0-rc.3 milestone Mar 4, 2020
@detiber
Copy link
Member

detiber commented Mar 4, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit e9038a5 into kubernetes-sigs:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@randomvariable randomvariable Awaiting requested review from randomvariable

Assignees

@detiber detiber

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.0-rc.3
Development

Successfully merging this pull request may close these issues.

[doc] book image references are wrong Fix state diagram for control plane controller
4 participants
@chuckha @k8s-ci-robot @detiber @vincepri