Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] book image references are wrong #2528

Closed
chuckha opened this issue Mar 4, 2020 · 3 comments · Fixed by #2529
Closed

[doc] book image references are wrong #2528

chuckha opened this issue Mar 4, 2020 · 3 comments · Fixed by #2529
Assignees
@chuckha
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Milestone
v0.3.0-rc.3

Comments

@chuckha
Copy link
Contributor

chuckha commented Mar 4, 2020

Looks like the controllers have all moved in one directory and caused the images to start 404ing. No big deal, just need to update the paths in the images.

/kind bug
/area documentation
/assign
/lifecycle active
/milestone v0.3.0-rc3
@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Mar 4, 2020
@k8s-ci-robot
Copy link
Contributor

@chuckha: The provided milestone is not valid for this repository. Milestones in this repository: [Next, v0.2.x, v0.3.0-rc.3, v0.3.0, v0.3.x]

Use /milestone clear to clear the milestone.

In response to this:

Looks like the controllers have all moved in one directory and caused the images to start 404ing. No big deal, just need to update the paths in the images.

/kind bug
/area documentation
/assign
/lifecycle active
/milestone v0.3.0-rc3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@chuckha: The label(s) area/documentation cannot be applied, because the repository doesn't have them

In response to this:

Looks like the controllers have all moved in one directory and caused the images to start 404ing. No big deal, just need to update the paths in the images.

/kind bug
/area documentation
/assign
/lifecycle active
/milestone v0.3.0-rc3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 4, 2020
@chuckha
Copy link
Contributor Author

chuckha commented Mar 4, 2020

/milestone v0.3.0-rc.3

@k8s-ci-robot k8s-ci-robot added this to the v0.3.0-rc.3 milestone Mar 4, 2020
@chuckha chuckha mentioned this issue Mar 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuckha chuckha

Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Milestone
v0.3.0-rc.3
Development

Successfully merging a pull request may close this issue.

📖 Update controller images in book chuckha/cluster-api
2 participants
@chuckha @k8s-ci-robot