✨clusterctl: make template object more generic #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/clusterctl
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
ncdc
reviewed
Feb 4, 2020
| variables: variables, | ||
| targetNamespace: options.targetNamespace, | ||
| objs: objs, | ||
| }, nil | ||
| } | ||
|
|
||
| // NewTemplate returns a new template object | ||
| func NewTemplate(yaml []byte, configVariablesClient config.VariablesClient, targetNamespace string) (*template, error) { |
There was a problem hiding this comment.
Do we need both a private and a public constructor?
fabriziopandini
force-pushed
the
clusterctl-make-template-generic
branch
from
9ea30e1 to
2dab84b
Compare
|
@ncdc comment addressed! |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR creates the ground for implementing #2133 by dropping all the template attributes derived by the provider repository.
Those attributes were originally implemented mirroring the solution implemented for the component YAML, but today they are not used anywhere.
As soon as the simplified Template object is ready, then it will be easier to add code for reading templates from sources different than the provider repository (GitHub, FileSystem, ConfigMaps)
Which issue(s) this PR fixes
Rif #2133
/area clusterctl
/assign @ncdc
/assign @vincepri