Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clusterctl to specify a custom Workload Cluster template #2133

Closed
aaroniscode opened this issue Jan 23, 2020 · 4 comments · Fixed by #2265
Closed

Allow clusterctl to specify a custom Workload Cluster template #2133

aaroniscode opened this issue Jan 23, 2020 · 4 comments · Fixed by #2265
Labels
area/clusterctl Issues or PRs related to clusterctl help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@aaroniscode
Copy link
Contributor

User Story

As an operator I would like to be able to choose between multiple Workload Cluster templates when using clusterctl to create a new Workload Cluster. I might do this for a few reasons:

  • Test different configurations. For example a CAPA cluster template designed to use Calico CNI and another CAPA cluster template designed to use VPC CNI.
  • Test a configuration change, like adding Audit configuration to the KubeadmConfig

Detailed Description

As an operator I would like to store my Workload Cluster templates in source control, like GitHub. When deploying a cluster using clusterctl I'd like to be able to choose the template, like:

clusterctl config cluster dev --source=https://github.com/aaroniscode/capi-templates/capa-vpc-cni.yaml

Might also want to be able to use a local file

clusterctl config cluster dev --source=~/templates/capa-vpc-cni.yaml

/kind feature
/area clusterctl

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/clusterctl Issues or PRs related to clusterctl labels Jan 23, 2020
@aaroniscode
Copy link
Contributor Author

Some additional notes:

As @Arvinderpal pointed out in Slack, the --flavor flag could be used to point to different templates if the source could be changed to a different Github repository, and one where you don't have the requirement to publish a release.

Also when the filesystem backed is merged #1963, having the option to use a local template on the filesystem would be a good option to have.

@ncdc ncdc added this to the v0.3.0 milestone Jan 29, 2020
@ncdc ncdc added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jan 29, 2020
@ncdc
Copy link
Contributor

ncdc commented Jan 29, 2020

/help

@k8s-ci-robot
Copy link
Contributor

@ncdc:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 29, 2020
@fabriziopandini
Copy link
Member

/lifecycle active
As per various discussions, including also:

  • read templates from ConfigMap
  • allow listing variables required by a workload cluster template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterctl Issues or PRs related to clusterctl help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants