Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sample/machineset.yaml to use new field and match docker version in machines.yaml.template #126

Merged
merged 1 commit into from
May 3, 2018
Merged

Update sample/machineset.yaml to use new field and match docker version in machines.yaml.template #126

merged 1 commit into from
May 3, 2018

Conversation

k4leung4
Copy link
Contributor

@k4leung4 k4leung4 commented May 2, 2018

What this PR does / why we need it:
Have docker version and os match that of the machine template

@kubernetes/kube-deploy-reviewers

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 2, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @k4leung4. Thanks for your PR.

I'm waiting for a kubernetes or kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k4leung4
Copy link
Contributor Author

k4leung4 commented May 2, 2018

/assign @kcoronado @krousey

kcoronado
kcoronado reviewed May 2, 2018
View reviewed changes
sample/machineset.yaml Outdated
@@ -19,9 +19,10 @@ spec:
project: "$GCLOUD_PROJECT"
zone: "us-central1-f"
machineType: "n1-standard-1"
os: "ubuntu-1604-lts"
image: "projects/ubuntu-os-cloud/global/images/family/ubuntu-1604-lts"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the same ProviderConfig type as the one for GCE? If so, the image field was replaced by the os field so you should get rid of this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the other way around, you want to keep the os field and get rid of the image field (sorry)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying again.

@kcoronado
Copy link
Contributor

lgtm
/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@kcoronado: you can't request testing unless you are a kubernetes or kubernetes-sigs member.

In response to this:

lgtm
/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spew
Copy link
Contributor

spew commented May 3, 2018

Hello Kenny,

Please squash these three commits down to a single commit. Also, please update the commit message with what is being updated in machineset.yaml. It could be "Update machineset.yaml sample to include the latest fields".

Also recommend calling it "sample/machineset.yaml" instead of "machineset.yaml sample".

@k4leung4 k4leung4 changed the title Update machineset.yaml sample Update sample/machineset.yaml to use new field and match docker version in machines.yaml.template May 3, 2018
@k4leung4
Copy link
Contributor Author

k4leung4 commented May 3, 2018

thanks for the suggestion.
squashed and update commit message.

@krousey
Copy link
Contributor

krousey commented May 3, 2018

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k4leung4, krousey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit ed96709 into kubernetes-sigs:master May 3, 2018
chuckha pushed a commit to chuckha/cluster-api that referenced this pull request Oct 2, 2019
@k8s-ci-robot
Merge pull request kubernetes-sigs#126 from chuckha/update-imports
5a2bd2a 
Change imports from v1alpha1 to v1alpha2
chuckha pushed a commit to chuckha/cluster-api that referenced this pull request Oct 2, 2019
@k8s-ci-robot
Merge pull request kubernetes-sigs#126 from newrelic-forks/cert-secret
97e65c6 
Add certificate generation and secret lookup to bootstrap controller
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this pull request Jan 31, 2020
@k8s-ci-robot
Removed terraform actuators (kubernetes-sigs#126)
e4135d6 
Removed the terraform actuator code.  Removed the terraform install in the
Dockerfile.  Updated all the code to remove MachineVariables.  This
actuator is no longer being maintain and slowly falling behind the govmomi
actuators.

Resolves kubernetes-sigs#125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcoronado kcoronado kcoronado left review comments

Assignees

@krousey krousey

@kcoronado kcoronado

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@k4leung4 @k8s-ci-robot @kcoronado @spew @krousey