-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move cloud/google/machineactuator.go's version of GCEProviderConfig f… #125
Move cloud/google/machineactuator.go's version of GCEProviderConfig f… #125
Conversation
…rom internal to v1alpha1.
Hi @spew. Thanks for your PR. I'm waiting for a kubernetes or kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Note, for testing done, I ran "./gcp-deployer create -m machines.yaml -c cluster.yaml" sucessfully. See below:
|
/ok-to-test |
@spew: you can't request testing unless you are a kubernetes or kubernetes-sigs member. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krousey, spew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Removed the terraform actuator code. Removed the terraform install in the Dockerfile. Updated all the code to remove MachineVariables. This actuator is no longer being maintain and slowly falling behind the govmomi actuators. Resolves kubernetes-sigs#125
Resolves kubernetes-sigs#125 Change-Id: I270c2678dd2d9ee4984cf1d61e7c629997ea1da0
…rom internal to v1alpha1.
What this PR does / why we need it:
This PR moves machineactuator's usage GCEProviderConfig from internal to the v1alpha1 implementation.
The intention for cloud/google/machineactuator.go is for it to operate on the latest API versions at all times. To that end, it should be using the v1alpha1 version of GCEProviderConfig instead of the "internal" version. The internal version operates as a hub so each spoke (i.e. version) can be converted to internal and then to the latest version for the rest of the codebase to use.
Release note:
@kubernetes/kube-deploy-reviewers