Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cloud/google/machineactuator.go's version of GCEProviderConfig f… #125

Merged

Conversation

spew
Copy link
Contributor

@spew spew commented May 2, 2018

…rom internal to v1alpha1.

What this PR does / why we need it:
This PR moves machineactuator's usage GCEProviderConfig from internal to the v1alpha1 implementation.

The intention for cloud/google/machineactuator.go is for it to operate on the latest API versions at all times. To that end, it should be using the v1alpha1 version of GCEProviderConfig instead of the "internal" version. The internal version operates as a hub so each spoke (i.e. version) can be converted to internal and then to the latest version for the rest of the codebase to use.

Release note:

NONE

@kubernetes/kube-deploy-reviewers

@spew spew requested review from krousey, kcoronado and jessicaochen May 2, 2018 21:18
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 2, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @spew. Thanks for your PR.

I'm waiting for a kubernetes or kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 2, 2018
@spew
Copy link
Contributor Author

spew commented May 2, 2018

Note, for testing done, I ran "./gcp-deployer create -m machines.yaml -c cluster.yaml" sucessfully. See below:

$ go build

$ ./gcp-deployer create -m machines.yaml -c cluster.yaml 
I0502 14:07:11.727615    3259 deploy_helper.go:58] Starting cluster creation test1
I0502 14:07:11.727818    3259 deploy_helper.go:60] Starting master creation gce-master-test1
I0502 14:07:14.094568    3259 machineactuator.go:586] Wait for insert "operation-1525295232343-56b3f78805bd8-7c297a1d-42d9efb8"...
I0502 14:07:24.653350    3259 machineactuator.go:596] Finish wait for insert "operation-1525295232343-56b3f78805bd8-7c297a1d-42d9efb8"...
I0502 14:07:24.653375    3259 deploy_helper.go:67] Created master gce-master-test1
I0502 14:07:24.827014    3259 deploy_helper.go:210] Waiting for Kubernetes to come up...
I0502 14:07:53.377620    3259 deploy_helper.go:210] Waiting for Kubernetes to come up...
I0502 14:08:09.492768    3259 deploy_helper.go:210] Waiting for Kubernetes to come up...
I0502 14:08:26.014788    3259 deploy_helper.go:210] Waiting for Kubernetes to come up...
I0502 14:08:43.607984    3259 deploy_helper.go:210] Waiting for Kubernetes to come up...
I0502 14:09:04.407132    3259 deploy_helper.go:210] Waiting for Kubernetes to come up...
I0502 14:09:07.900772    3259 deploy_helper.go:219] Kubernetes is up.. Writing kubeconfig to disk.
I0502 14:09:07.903261    3259 deploy_helper.go:256] wrote kubeconfig to [/Users/rleidle/.kube/config]
I0502 14:09:07.903323    3259 deploy_helper.go:272] Waiting for apiserver to become healthy...
I0502 14:09:12.979358    3259 deploy_helper.go:272] Waiting for apiserver to become healthy...
I0502 14:09:22.792474    3259 deploy_helper.go:272] Waiting for apiserver to become healthy...
I0502 14:09:28.272980    3259 deploy_helper.go:272] Waiting for apiserver to become healthy...
I0502 14:09:34.761780    3259 deploy_helper.go:272] Waiting for apiserver to become healthy...
I0502 14:09:34.823234    3259 deploy_helper.go:287] Waiting for the service account to exist...
I0502 14:09:41.385350    3259 deploy_helper.go:287] Waiting for the service account to exist...
I0502 14:09:50.880959    3259 deploy_helper.go:287] Waiting for the service account to exist...
I0502 14:09:50.894269    3259 deploy_helper.go:90] Deploying the addon apiserver and controller manager...
I0502 14:10:33.739906    3259 deploy_helper.go:137] Added machine [gce-master-test1]
I0502 14:10:33.833949    3259 deploy_helper.go:137] Added machine [gce-node-p7crq]
I0502 14:10:33.833968    3259 deploy.go:80] The [test1] cluster has been created successfully!
I0502 14:10:33.833974    3259 deploy.go:81] You can now `kubectl get nodes`

$ ./gcp-deployer delete
I0502 14:11:35.254854    3529 deploy.go:107] Deleting machine objects
I0502 14:12:02.861343    3529 deploy_helper.go:156] Deleted machine object gce-node-p7crq
I0502 14:12:02.861374    3529 deploy.go:130] Deleting master vm gce-master-test1
I0502 14:12:04.195850    3529 machineactuator.go:586] Wait for delete "operation-1525295523457-56b3f89da67e9-9544961c-c6b86af8"...
I0502 14:12:41.231066    3529 machineactuator.go:596] Finish wait for delete "operation-1525295523457-56b3f89da67e9-9544961c-c6b86af8"...
I0502 14:12:41.231121    3529 deploy.go:116] Running post delete operations
I0502 14:12:44.636742    3529 deploy.go:120] Deletion complete

@spew
Copy link
Contributor Author

spew commented May 2, 2018

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@spew: you can't request testing unless you are a kubernetes or kubernetes-sigs member.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krousey
Copy link
Contributor

krousey commented May 2, 2018

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krousey, spew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2018
@k8s-ci-robot k8s-ci-robot merged commit 818a6d1 into kubernetes-sigs:master May 2, 2018
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this pull request Jan 31, 2020
Removed the terraform actuator code.  Removed the terraform install in the
Dockerfile.  Updated all the code to remove MachineVariables.  This
actuator is no longer being maintain and slowly falling behind the govmomi
actuators.

Resolves kubernetes-sigs#125
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this pull request Jan 31, 2020
Resolves kubernetes-sigs#125
Change-Id: I270c2678dd2d9ee4984cf1d61e7c629997ea1da0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants