Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plantuml generation to use CAPI-managed image #1194

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Update plantuml generation to use CAPI-managed image #1194

merged 1 commit into from
Jul 24, 2019

Conversation

detiber
Copy link
Member

@detiber detiber commented Jul 24, 2019

What this PR does / why we need it:
Updates plantuml generation to use CAPI-managed image

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1070

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2019
@k8s-ci-robot k8s-ci-robot requested review from ncdc and vincepri July 24, 2019 20:56
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 24, 2019
@detiber
Copy link
Member Author

detiber commented Jul 24, 2019

/hold
blocked on kubernetes/k8s.io#322 and validation that promoted image is available.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2019
@detiber
Copy link
Member Author

detiber commented Jul 24, 2019

Image promoter PR has been merged, but promotion job failed: https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/post-k8sio-cip/1154134770209263616, waiting for confirmation that the job has been successfully re-run.

vincepri
vincepri approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2019
@detiber
Copy link
Member Author

detiber commented Jul 24, 2019

Job rerun was successful: https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/post-k8sio-cip/1154137402810306560

Local testing shows that this appears to work as expected.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit d8b90c5 into kubernetes-sigs:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish a plantuml image owned by CAPI
3 participants
@detiber @k8s-ci-robot @vincepri