Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish a plantuml image owned by CAPI #1070

Closed
dlipovetsky opened this issue Jun 25, 2019 · 6 comments · Fixed by #1194
Closed

Publish a plantuml image owned by CAPI #1070

dlipovetsky opened this issue Jun 25, 2019 · 6 comments · Fixed by #1194
Assignees
@justinsb @dlipovetsky
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v0.2.0 (v1alpha2)

Comments

@dlipovetsky
Copy link
Contributor

In #1058, I use the PlantUML CLI to generate sequence diagrams for proposals and docs. It needs the Java runtime and some fonts, so it is run in a container with those dependencies provided. The container is currently published on docker hub. Let's publish it using the official k8s channels.
@timothysc timothysc added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jun 26, 2019
@timothysc timothysc added this to the v1alpha2 milestone Jun 26, 2019
@timothysc
Copy link
Member

@justinsb we should sync with @dims && k8s-infra on how we manage shared infra containers.
/cc @spiffxp

@dlipovetsky
Copy link
Contributor Author

I'll PR the Dockerfile to this repo as a first step

@dlipovetsky dlipovetsky mentioned this issue Jul 3, 2019
Merged
@dims
Copy link
Member

dims commented Jul 5, 2019

@dlipovetsky @timothysc i've got the ball rolling by notifying kubernetes-dev on the steps we support [1]

[1] https://groups.google.com/d/msg/kubernetes-dev/ZqdjjDIAISY/n5USEpPBCgAJ

@detiber
Copy link
Member

detiber commented Jul 5, 2019

@dims is use of the image-promoter now allowed?

@dims
Copy link
Member

dims commented Jul 5, 2019

@detiber yes, please try it

@detiber
Copy link
Member

detiber commented Jul 24, 2019

Request for promotion for an initial image for this is here: kubernetes/k8s.io#322

@detiber detiber mentioned this issue Jul 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinsb justinsb

@dlipovetsky dlipovetsky

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v0.2.0 (v1alpha2)
Development

Successfully merging a pull request may close this issue.

Update plantuml generation to use CAPI-managed image detiber/cluster-api
5 participants
@dims @justinsb @timothysc @detiber @dlipovetsky