Merge pull request #2740 from vincepri/actually-return

🐛 MachineDeployment controller should actually return errors
kubernetes-sigs · Mar 20, 2020 · e0c232b · e0c232b
2 parents a97903f + 83bf04e
commit e0c232b
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/controllers/machinedeployment_controller.go b/controllers/machinedeployment_controller.go
@@ -127,8 +127,7 @@ func (r *MachineDeploymentReconciler) Reconcile(req ctrl.Request) (_ ctrl.Result
 		logger.Error(err, "Failed to reconcile MachineDeployment")
 		r.recorder.Eventf(deployment, corev1.EventTypeWarning, "ReconcileError", "%v", err)
 	}
-
-	return result, nil
+	return result, err
 }
 
 func (r *MachineDeploymentReconciler) reconcile(ctx context.Context, cluster *clusterv1.Cluster, d *clusterv1.MachineDeployment) (ctrl.Result, error) {