Skip to content

Commit

Permalink
Merge pull request #2733 from vincepri/binaries-first
Browse files Browse the repository at this point in the history
🏃 Build binaries first during release
  • Loading branch information
k8s-ci-robot authored Mar 19, 2020
2 parents f34d70d + 594de67 commit a97903f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,8 @@ release: clean-release ## Builds and push container images using the latest git
@if [ -z "${RELEASE_TAG}" ]; then echo "RELEASE_TAG is not set"; exit 1; fi
@if ! [ -z "$$(git status --porcelain)" ]; then echo "Your local git repository contains uncommitted changes, use git clean before proceeding."; exit 1; fi
git checkout "${RELEASE_TAG}"
# Build binaries first.
$(MAKE) release-binaries
# Set the core manifest image to the production bucket.
$(MAKE) set-manifest-image \
MANIFEST_IMG=$(PROD_REGISTRY)/$(IMAGE_NAME) MANIFEST_TAG=$(RELEASE_TAG) \
Expand All @@ -433,7 +435,6 @@ release: clean-release ## Builds and push container images using the latest git
$(MAKE) set-manifest-pull-policy PULL_POLICY=IfNotPresent TARGET_RESOURCE="./bootstrap/kubeadm/config/manager/manager_pull_policy.yaml"
$(MAKE) set-manifest-pull-policy PULL_POLICY=IfNotPresent TARGET_RESOURCE="./controlplane/kubeadm/config/manager/manager_pull_policy.yaml"
$(MAKE) release-manifests
$(MAKE) release-binaries

.PHONY: release-manifests
release-manifests: $(RELEASE_DIR) $(KUSTOMIZE) ## Builds the manifests to publish with a release
Expand Down

0 comments on commit a97903f

Please sign in to comment.